Implemented interactive buffers. #28
Conversation
|
Thanks for the PR. I'll review this by June 13th.
|
| @@ -1,4 +1,4 @@ | |||
| function! s:llnotify(event, ...) abort | |||
| function! lldb#remote#llnotify(event, ...) abort | |||
There was a problem hiding this comment.
This is probably better named as lldb#remote#_notify (or even __notify).
|
Other than the comments I left, it looks great! |
|
Looks good! To properly take advantage of your code, I have mapped the Can you squash the last 2 of your commits and cherry-pick those 2 commits I added (after reviewing those changes)? I will merge it as soon as you are ready. |
* Breakpoint buffer: delete buffer with 'x' * Backtrace buffer: select frame with '<CR>' * Thread buffer: select thread with '<CR>' The 'llnotify' function is promoted to global namespace.
- Mapped `a` and `t` in backtrace and threads buffer
|
The 2 commits lgtm. |
|
Great! Thanks again! |
Implements the feature in #9, except for the watchpoints.
In the end, I skip the syntax idea all together, and perform the regex myself. The ideal way is to extract substring using Vim's syntax mechanism, but the most I can do is looking up what syntax group a specific location belongs to. If I want to do anything more, I might need to scan the whole line, which makes things more complicated.
Also, I promoted "llnotify" to global namespace because it's now used in layout.vim as well. I understand this is probably something to hide from the user. Maybe we need another commit to re-organize the functions.