Upgrade faraday to 2.x #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarwood
force-pushed
the
upgrade-faraday-to-2.x
branch
from
672c0d5
to
ec8f128
Compare
this removes faraday_middleware (due to faraday 2.0 changes), adds faraday-multipart and updates related class references. additionally, faraday's minimum version is now set at 2.0.1 per https://github.com/lostisland/faraday/blob/main/UPGRADING.md to avoid missing net_http issues
dgarwood
force-pushed
the
upgrade-faraday-to-2.x
branch
from
ec8f128
to
d7d09c1
Compare
|
Let's bump to 0.4.0 as part of this PR? Please check slack-ruby/slack-ruby-client#406 and slack-ruby/slack-ruby-client#434 that had to do more involved things for this upgrade. Looks like some error handling differences, etc. Also do we need something in UPGRADING.md? |
|
Any chance we can get this PR pushed through? We'd like to bump https://github.com/andreibondarev/langchainrb faraday to 2.x and this gem is one of the deps. Thank you! |
|
I merged it since it's green, will increment the version and cut a release. |
|
@andreibondarev And done, use 0.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.