Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rubocop #40

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Fix/rubocop #40

merged 3 commits into from
Jul 5, 2024

Conversation

troya2
Copy link
Collaborator

@troya2 troya2 commented Jul 4, 2024

Fixed rubocop violations and improved .rubocop.yml by adding in suggested cops and disabling a few to avoid making changes to the gemspec. I'd be fine with making those changes, but didn't seem necessary.

…ase the cop.

Removed .rubocop_todo.yml as it's no longer needed to pass rubocop.
Copy link
Owner

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t love the long list of enables cops, I’d rather enable them all and disable ones that are in violation but YOLO.

@dblock dblock merged commit 2274c1a into dblock:master Jul 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants