Added additional VCR responses from openweather that includes all dat… #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troya2
force-pushed
the
improvement/hourly-tests
branch
from
fc6cbcf
to
ad9e2f5
Compare
* Rubocop autocorrections * Revert "Rubocop autocorrections" This reverts commit 6a044fc. * Updated .rubocop.yml with suggested rules and applied changes to appease the cop. Removed .rubocop_todo.yml as it's no longer needed to pass rubocop.
dblock
approved these changes
Jul 5, 2024
…weather-ruby-client into feature/30-day-forecast # Conflicts: # CHANGELOG.md
Added support for the thirty day forecast in the pro 2.5 API
…a types - i.e. rain and snow
…-weather-ruby-client into improvement/hourly-tests # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; improved specs for the hourly forecasts API
I received an openweather API key for pro URLs, so I used that to get additional VCR data and added specs with that additional data that also includes snow and rain forecasts.