Merge pull request #218 from dbmdz/fix-error-in-error

Fixed 404 handling on deletions

CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ## Unreleased
 
+### Fixed
+
+- A deletion of a nonexistant resource no longer leads to a client error
+
 ## [9.4.0](https://github.com/dbmdz/metadata-service/releases/tag/9.4.0) - 2024-12-06
 
 ### Added

metasvc-client/src/main/java/de/digitalcollections/client/BaseRestClient.java

@@ -191,13 +191,14 @@ private HttpRequest createPutRequest(String requestUrl, Object bodyObject)
   protected String doDeleteRequestForString(String requestUrl) throws TechnicalException {
     HttpRequest req = createDeleteRequest(requestUrl);
     try {
-      HttpResponse<String> response = http.send(req, HttpResponse.BodyHandlers.ofString());
+      HttpResponse<byte[]> response = http.send(req, HttpResponse.BodyHandlers.ofByteArray());
       Integer statusCode = response.statusCode();
       if (statusCode >= 400) {
         throw HttpErrorDecoder.decode("DELETE " + requestUrl, statusCode, response);
       }
-      String body = response.body();
-      if (body == null || body.isBlank()) {
+      // This is the most performant approach for Jackson
+      final byte[] body = response.body();
+      if (body == null || body.length == 0) {
         return null;
       }
       String result = mapper.readerFor(String.class).readValue(body);