Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename locale to pLocale in the client #64

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Rename locale to pLocale in the client #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ This version changes both the `groupId` and `artifactId` of the contained maven

- Several missing `equals` & `hashCode` methods are added to model classes
- Order of a website's root webpages is retained
- Renamed parameter `locale` to `pLocale` in the client

## [8.0.3](https://github.com/dbmdz/cudami/releases/tag/8.0.3) – 2024-01-19

Expand Down
2 changes: 1 addition & 1 deletion ...main/java/de/digitalcollections/cudami/client/identifiable/CudamiIdentifiablesClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public I getByUuidAndLocale(UUID uuid, Locale locale) throws TechnicalException

public I getByUuidAndLocale(UUID uuid, String locale) throws TechnicalException {
try {
return doGetRequestForObject(String.format(baseEndpoint + "/%s?locale=%s", uuid, locale));
return doGetRequestForObject(String.format(baseEndpoint + "/%s?pLocale=%s", uuid, locale));
} catch (ResourceNotFoundException e) {
return null;
}
Expand Down
4 changes: 2 additions & 2 deletions ...a/de/digitalcollections/cudami/client/identifiable/BaseCudamiIdentifiablesClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public void testGetByUuidAndLocale() throws Exception {
Locale locale = Locale.GERMAN;
client.getByUuidAndLocale(uuid, locale);

verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?locale=" + locale);
verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?pLocale=" + locale);
}

@Test
Expand All @@ -75,7 +75,7 @@ public void testGetByUuidAndLocaleAsString() throws Exception {
String locale = Locale.GERMAN.toString();
client.getByUuidAndLocale(uuid, locale);

verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?locale=" + locale);
verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?pLocale=" + locale);
}

@Test
Expand Down
Loading