Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict behavior flags to firing a warning only the first time #197

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

mikealfare
Copy link
Contributor

resolves dbt-labs/dbt-redshift#915

Description

We're firing a warning per model for behavior changes. We should fire a warning per run.

Checklist

@mikealfare mikealfare self-assigned this Sep 20, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 20, 2024 20:54
@cla-bot cla-bot bot added the cla:yes label Sep 20, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (7e2edee) to head (069190c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   67.35%   67.37%   +0.01%     
==========================================
  Files          52       52              
  Lines        3370     3372       +2     
==========================================
+ Hits         2270     2272       +2     
  Misses       1100     1100              
Flag Coverage Δ
unit 67.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare
Copy link
Contributor Author

I've verified locally that the warning only shows once in the logs for the dbt-redshift flag, but I'm having a tough time grabbing the event manager in the testing setup to verify it programmatically.

@mikealfare
Copy link
Contributor Author

Got it: dbt-labs/dbt-redshift#916

@colin-rogers-dbt colin-rogers-dbt added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 5d1d82a Sep 23, 2024
16 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the behavior-flags-fire-once branch September 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Reduce warnings with singular restrict_direct_pg_catalog_access message
4 participants