Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShowNode and CompiledNode to PrintEvent as special case, quiet-compatible events #216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 5, 2024

Description

Supports dbt-labs/dbt-core#9958

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.48%. Comparing base (5a401a9) to head (0aee79d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   68.48%   68.48%           
=======================================
  Files          52       52           
  Lines        3389     3389           
=======================================
  Hits         2321     2321           
  Misses       1068     1068           
Flag Coverage Δ
unit 68.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeatty10 dbeatty10 marked this pull request as ready for review November 5, 2024 17:35
@dbeatty10 dbeatty10 requested a review from a team as a code owner November 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants