-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tests: -> data_tests: in README.md #945
Conversation
@dbeatty10 Could you review this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like #893 intentionally only changed the integration_tests
folder in order for it to be a non-breaking change.
So I think we're going to leave the documentation as-is.
If we did choose to merge this change, it would need to be data_tests:
(underscore!) rather than data-tests:
.
@dbeatty10 Thank you for your response. I have corrected According to the official documentation, |
Is avoiding the warning your primary concern here? Or alignment with the official documentation? It's okay if your main concern is both or something completely else too! If it's the warning, we do have an open issue to cease raising a warning here: dbt-labs/dbt-core#10564. We'd probably update the official documentation at the same time. |
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
resolves #894
Problem
Solution
Checklist