Conversation
QMalcolm
force-pushed
the
qmalcolm--sync-dsi-final
branch
from
956e179 to
dc708b4
Compare
|
This is a stacked PR |
theyostalservice
left a comment
theyostalservice
left a comment
There was a problem hiding this comment.
Approved, but with the caveat that I'm concerned about the type ignores, and if we can avoid them, I'd really prefer that.
| "join_to_timespine": {"type": "boolean"}, | ||
| "fill_nulls_with": {"type": "integer"}, | ||
| "metric_aggregation_params": {"$ref": "metric_aggregation_params_schema"}, | ||
| "is_private": {"type": "boolean"}, |
There was a problem hiding this comment.
when was the last time this was synced? this change is really old
There was a problem hiding this comment.
The last time we synced I believe was in October of 2025 via #1895
metricflow-semantic-interfaces/metricflow_semantic_interfaces/implementations/saved_query.py
Outdated
Show resolved
Hide resolved
...flow-semantic-interfaces/metricflow_semantic_interfaces/parsing/text_input/ti_description.py
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| def __init_subclass__(cls, **kwargs) -> None: | ||
| def __init_subclass__(cls, **kwargs: Any) -> None: # type: ignore[misc] |
There was a problem hiding this comment.
Hmmmmm I'll see what I can do about **kwargs typing. There is Unpack but I've never used it before 🤔
There was a problem hiding this comment.
The most common thing we do in the repository is that when **kwargs is present is that we don't type it, and we set # type: ignore[no-untyped-def]. I am going to go down that path. There are some places when we know exactly the shape we expect of **kwargs, and thus we type it. But in this case we're defining it on an ABC generic inheritable class, and we don't know the expected shape of **kwargs in the least 🫠
| time: 2026-03-25T18:16:21.259009-05:00 | ||
| custom: | ||
| Author: QMalcolm | ||
| Issue: NA |
There was a problem hiding this comment.
please replace this with 2001 :P
There was a problem hiding this comment.
Core habits die hard 🙈
QMalcolm
force-pushed
the
qmalcolm--sync-dsi-final
branch
from
dc708b4 to
53ee89b
Compare
2 participants
We're collapsing DSI into MetricFlow. This is the final sync to do that, and in the coming weeks we'll archive the DSI repository.