New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-parent functions to be cast #128

Merged

dburgener merged 10 commits into dburgener:main from matt-sheets:masheets/more-cast-checking

Mar 17, 2023

Collaborator

matt-sheets commented Feb 22, 2023

Previously one could only cast a function if it was from an inherited type. Now you can cast a function as long as the function does not reference any associated types.

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

data/policies/parent_call.cas Show resolved Hide resolved

dburgener reviewed

View reviewed changes

data/error_policies/parent_call.cas Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

data/policies/parent_call.cas Show resolved Hide resolved

data/policies/parent_call.cas Show resolved Hide resolved

matt-sheets force-pushed the masheets/more-cast-checking branch from 52f8477 to a1de2f4 Compare

February 28, 2023 22:10

matt-sheets marked this pull request as ready for review

February 28, 2023 22:10

dburgener reviewed

View reviewed changes

data/policies/call_casting.cas Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/functions.rs Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

Owner

dburgener commented Mar 2, 2023

Can you split the commits so that the recursion testing is a separate commit from the casting?

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

matt-sheets force-pushed the masheets/more-cast-checking branch from a1de2f4 to 06b43ee Compare

March 6, 2023 16:21

matt-sheets mentioned this pull request

Analyze and improve pre-validation steps #138

Open

matt-sheets force-pushed the masheets/more-cast-checking branch from 06b43ee to e6a92a6 Compare

March 6, 2023 17:25

dburgener mentioned this pull request

Clean up function argument handling (part 1) #141

Merged

matt-sheets added 8 commits

March 15, 2023 22:22


          Allow non-parent functions to be cast

99aab2d

Previously one could only cast a function if it was from an inherited
type.  Now you can cast a function as long as the function does not
reference any associated types.


          fixing this.* case

35e20d8


          Updating test name changes

8f7f122


          adding recursion test

feba858


          review comments -wip


          added code to iterate through if and optional blocks

6ae1f24


          recursion check passes around strings instead of funcInfo

0d03765


          moving helper functions to functions.rs

8262ee5

matt-sheets added 2 commits

March 15, 2023 22:29


          review comments

82dfa40


          adding comments

dabae1a

dburgener reviewed

View reviewed changes

src/compile.rs Outdated Show resolved Hide resolved

src/ast.rs Show resolved Hide resolved

src/functions.rs Outdated Show resolved Hide resolved

src/compile.rs Outdated Show resolved Hide resolved

dburgener requested changes

View reviewed changes

src/functions.rs Outdated Show resolved Hide resolved

src/functions.rs Outdated Show resolved Hide resolved

src/functions.rs Outdated Show resolved Hide resolved

matt-sheets force-pushed the masheets/more-cast-checking branch from e70e8c4 to 82dfa40 Compare

March 16, 2023 20:01

dburgener reviewed

View reviewed changes

src/functions.rs Show resolved Hide resolved

dburgener approved these changes

View reviewed changes

dburgener merged commit f9ecf1f into dburgener:main

Owner

dburgener commented Mar 17, 2023

Merged, thanks!

dburgener added a commit that referenced this pull request


          Improve the error message when an annotation is both inherited and

1bdc404

explicitly declared.

This is mostly done, but still a bit of a WIP:

1. The todo!() is waiting on the merge of #128
2. This all got quite verbose, and should become its own function to
improve readability
3. The test is written, but not added in lib.rs

dburgener added a commit that referenced this pull request


          Improve the error message when an annotation is both inherited and

c9ef9f4

explicitly declared.

This is mostly done, but still a bit of a WIP:

1. The todo!() is waiting on the merge of #128
2. This all got quite verbose, and should become its own function to
improve readability
3. The test is written, but not added in lib.rs

dburgener added a commit that referenced this pull request


          Improve the error message when an annotation is both inherited and

4bec64d

explicitly declared.

This is mostly done, but still a bit of a WIP:

1. The todo!() is waiting on the merge of #128
2. This all got quite verbose, and should become its own function to
improve readability
3. The test is written, but not added in lib.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet