Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running action inside containers #10

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Support running action inside containers #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d10cd46
Add container tests
TaxBusby Nov 7, 2023
a039cbb
Update github actions path to fix container compat
TaxBusby Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 147 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,153 @@ jobs:
if [ -n "${_err}" ]; then exit 1; fi;


- name: Check jq - Windows-ish
if: runner.os == 'Windows' && matrix.force == 'true'
# language=powershell
run: |
Get-Command "jq.exe"
$_cmd={jq.exe --version }
$_vers=jq.exe --version 2>&1
if ( "${_vers}" -ne "jq-${{ matrix.version }}" -and "${_vers}" -ne "jq-${{ matrix.version }}-dirty" )
{
Write-Host "jq.exe --version returned unexpected value"
Write-Host " Expected: jq-${{ matrix.version }}"
Write-Host " Actual: ${_vers}"
exit 1
}

- name: Check Outputs - Windows-ish
if: runner.os == 'Windows'
shell: powershell
# language=powershell
run: |
$ErrorActionPreference = 'Stop'
Set-StrictMode -Version Latest
$_installed='${{ steps.install-jq.outputs.installed }}'
$_err = 0
if ("${{ matrix.force }}" -eq "true")
{
# enabling "force" must result in an install
if ("${{ steps.install-jq.outputs.installed }}" -ne "true")
{
Write-Host "Unexpected value for installed"
Write-Host "Expected: true"
Write-Host "Actual: ${{ steps.install-jq.outputs.installed }}"
$_err=1
}
}
else
{
if ("${{ steps.install-jq.outputs.found }}" -eq "true")
{
# if found, must not be installed without force
if ("${{ steps.install-jq.outputs.installed }}" -ne "false")
{
Write-Host "Unexpected value for installed"
Write-Host "Expected: false"
Write-Host "Actual: ${{ steps.install-jq.outputs.installed }}"
$_err=1
}
}
else
{
# if not found, must be installed
if ("${{ steps.install-jq.outputs.installed }}" -ne "true") {
Write-Host "Unexpected value for installed"
Write-Host "Expected: true"
Write-Host "Actual: ${{ steps.install-jq.outputs.installed }}"
$_err=1
}
}
}
if ("${_err}" -ne 0)
{
exit 1
}
test-container:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff makes this hard to read, but I effectively duplicated the test-linux job here, removed non-linux matrix cases, and set up a container to run the tests.

strategy:
matrix:
image:
- "ubuntu-22.04"
- "ubuntu-20.04"
force:
- 'true'
- 'false'
version:
- '1.5'
- '1.6'
- '1.7'
name: "Test Action (Container) - (img: ${{ matrix.image }}; version: ${{ matrix.version }}; force: ${{ matrix.force }})"
runs-on: ${{ matrix.image }}
container:
image: node:18.12.1
steps:
- uses: actions/checkout@v4

- name: Setup jq
id: install-jq
uses: ./
with:
version: '${{ matrix.version }}'
force: '${{ matrix.force }}'

- name: Check jq - Unix-ish
if: (runner.os == 'Linux' || runner.os == 'macOS') && matrix.force == 'true'
# language=sh
run: |
_err=
_which="$(which jq)"
_vers="$(jq --version)"
if [[ "${_which}" != "$RUNNER_TOOL_CACHE/jq/jq" ]]; then
echo "jq found at unexpected path."
echo " Expected: \"$RUNNER_TOOL_CACHE/jq/jq\""
echo " Actual: \"${_which}\""
_err=1
fi
if [[ "${_vers}" != 'jq-${{ matrix.version }}' ]]; then
echo "jq --version returned unexpected value"
echo ' Expected: "jq-${{ matrix.version }}"'
echo " Actual: \"${_vers}\""
_err=1
fi
if [ -n "${_err}" ]; then exit 1; fi;

- name: Check Outputs - Unix-ish
if: runner.os == 'Linux' || runner.os == 'macOS'
# language=sh
run: |
_installed='${{ steps.install-jq.outputs.installed }}'
_err=
if [[ '${{ matrix.force }}' == 'true' ]]; then
# enabling "force" must result in an install
if [[ '${{ steps.install-jq.outputs.installed }}' != 'true' ]]; then
echo 'Unexpected value for "installed":'
echo 'Expected: "true"'
echo 'Actual: "${{ steps.install-jq.outputs.installed }}"'
_err=1
fi
else
if [[ '${{ steps.install-jq.outputs.found }}' == 'true' ]]; then
# if found, must not be installed without force
if [[ '${{ steps.install-jq.outputs.installed }}' != 'false' ]]; then
echo 'Unexpected value for "installed":'
echo 'Expected: "false"'
echo 'Actual: "${{ steps.install-jq.outputs.installed }}"'
_err=1
fi
else
# if not found, must be installed
if [[ '${{ steps.install-jq.outputs.installed }}' != 'true' ]]; then
echo 'Unexpected value for "installed":'
echo 'Expected: "true"'
echo 'Actual: "${{ steps.install-jq.outputs.installed }}"'
_err=1
fi
fi
fi
if [ -n "${_err}" ]; then exit 1; fi;


- name: Check jq - Windows-ish
if: runner.os == 'Windows' && matrix.force == 'true'
# language=powershell
Expand Down
4 changes: 2 additions & 2 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ runs:
env:
JQ_VERSION: '${{ inputs.version }}'
# language=sh
run: ${{ github.action_path }}/scripts/unixish.sh
run: ${GITHUB_ACTION_PATH}/scripts/unixish.sh

- name: 'Install jq - Unix-ish 1.7'
if: (runner.os == 'Linux' || runner.os == 'macOS') && inputs.version == '1.7' && (steps.jq-check-unix.outputs.found == 'false' || inputs.force == 'true')
shell: bash
env:
JQ_VERSION: '${{ inputs.version }}'
# language=sh
run: ${{ github.action_path }}/scripts/unixish-17.sh
run: ${GITHUB_ACTION_PATH}/scripts/unixish-17.sh

- name: 'Check for jq - Windows-ish'
id: jq-check-windows
Expand Down