Improve compatibility with docker 24.0.x #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 9 9
Lines 1002 1002
Branches 202 202
=======================================
Hits 948 948
Misses 40 40
Partials 14 14
|
The error message is now "Error from daemon: .... no such volume". So the colon after "Error" is now missing. Switch to a more specific part of the error message that appears to be more common across versions and variants
the new buildkit backend does no longer provide the stdout output that we'er expecting, so as a simple fix hard code the legacy one for now. This needs to be addressed in a larger rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message is now "Error from daemon: .... no such volume". So the colon after "Error" is now missing. Switch to a more specific part of the error message that appears to be more common across versions and variants