Use --iidfile & --cidfile to get the ctr & img ids #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 94.61% 88.73% -5.88%
==========================================
Files 9 9
Lines 1003 1030 +27
Branches 202 202
==========================================
- Hits 949 914 -35
- Misses 40 99 +59
- Partials 14 17 +3
|
We don't have to rely on stdout containing the img id, which is not the case with the newest docker.
This reverts commit 084d2bb.
Docker 24 stopped accepting image digests in the FROM line of a Dockerfile, hence we need to find a workaround. The simplest way is to tag the locally build images with something and the most straightforward way was to just pick the image digest and prefix it with pytest_container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have to rely on stdout containing the img id, which is not the case with the newest docker.