DerivedContainer inhertis container_id, url from the base on prepare #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the base is just a container image, then we want the url property to be set instead of the container_id as otherwise the _build_tag property will be `pytest_container:$url`
dcermak
force-pushed
the
fix-derived-url-id
branch
from
98917a6
to
d7cb602
Compare
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 88.73% 94.76% +6.02%
==========================================
Files 9 9
Lines 1030 1031 +1
Branches 202 208 +6
==========================================
+ Hits 914 977 +63
+ Misses 99 40 -59
+ Partials 17 14 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the base is just a container image, then we want the url property to be set instead of the
container_idas otherwise the_build_tagproperty will bepytest_container:$url