Stop container before removing it forcefully #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 94.96% 94.97%
=======================================
Files 9 9
Lines 1112 1114 +2
Branches 231 231
=======================================
+ Hits 1056 1058 +2
Misses 42 42
Partials 14 14 ☔ View full report in Codecov by Sentry. |
rcmadhankumar
force-pushed
the
fix-stop-container
branch
from
838c86f
to
c814c2d
Compare
dcermak
requested changes
Sep 20, 2024
rcmadhankumar
force-pushed
the
fix-stop-container
branch
from
c814c2d
to
1c266a5
Compare
dcermak
requested changes
Sep 20, 2024
rcmadhankumar
force-pushed
the
fix-stop-container
branch
2 times, most recently
from
3da2d36
to
618124e
Compare
|
@rcmadhankumar can you please rebase? The testsuite had unrelated issues that now got resolved. |
rcmadhankumar
force-pushed
the
fix-stop-container
branch
from
1ef2ed5
to
4bd02ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop container before removing it forcefully on exit.