New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - initial refactoring into a package #1

Open

crerwin wants to merge 3 commits into master from refactor-into-package

Collaborator

crerwin commented Oct 18, 2018 •

edited

Loading

Moved everything from util.go in the cmd package into a new dcosauth package in /pkg.
Made necessary functions exportable
Confirmed cli functionality didn't change.

Still needed (at a minimum):

comment exported functions
refactor for testability (for instance, to mock the API responses to test the Login and Refresh function, and to mock reading the key file)
internalize things that don't need to be external
lots of code repeat everywhere

crerwin added 3 commits

October 18, 2018 19:27


          initial refactoring into a package

bc7722e


          refactor command main and package up commands

5e74ddb


          comment exported functions and other lint fixes

75831ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet