Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OBR-Autonomous Labels #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added OBR-Autonomous Labels #55

wants to merge 5 commits into from

Conversation

BelleGarlick
Copy link

@BelleGarlick BelleGarlick commented Feb 12, 2020

Altered index.md, provided labels and logo.
Cheers

@ddavid
Copy link
Owner

ddavid commented Feb 20, 2020

Hi Sam, am midst in the exam period, will go over it at the beginning of next week.

@ddavid
Copy link
Owner

ddavid commented Feb 27, 2020

Hi Sam, please excuse the delay, got a bit under the weather after the trip back to Munich.
Will go through the PR later on tonight.

@ddavid
Copy link
Owner

ddavid commented Feb 28, 2020

Hi Sam, unfortunately there seems to be some labels without corresponding images. Could you please look into that? Maybe mismatched file names?

@BelleGarlick
Copy link
Author

Sorry about that, have pushed a fix with the correct labels.

@ddavid
Copy link
Owner

ddavid commented Feb 29, 2020

Will probably only be able to have a look tomorrow, when I have access to WiFi again.
Will keep you posted.

@ddavid
Copy link
Owner

ddavid commented Mar 5, 2020

Hi Sam,
still having similar issues with labels in the repo not having a corresponding image in the album you shared with me.
I've updated the draw_boxes script slightly. Feel free to use it to check if all labels and images are available. https://github.com/ddavid/fsoco/blob/master/scripts/draw_boxes_from_cwd.py
Furthermore, there is a float class index in label 122.txt, haven't looked beyond that one yet but that would also need to be fixed.

@BelleGarlick
Copy link
Author

BelleGarlick commented Mar 7, 2020

Hi David.

I've updated the problem with class numbers incorrectly stores as floats. I'm not sure how you're having issues with mis-matched images/labels. I've re-uploaded all the images into the album (to ensure you have the correct images): https://photos.app.goo.gl/7ymWVc9L7m8nDttQ8. Additionally I've run the code you provided over the images which can be found here: https://drive.google.com/file/d/1R37sIMSoaTKgWsyPmCjGmHqUcMxgOLhu/view?usp=sharing. I hope that kelps.

@ddavid
Copy link
Owner

ddavid commented Mar 9, 2020

Hi Sam,
I'll have a look tonight, thank you for going through it again.

@ddavid
Copy link
Owner

ddavid commented Mar 9, 2020

Hi Sam, thank you, the issue seems to be solved.
I've looked into it on my side and I think it was some issue with mixed jpg and png images in one directory.
The overall quality of the labels is really good, even more so through the HD images.
Unfortunately there's still a few images with wrong labels and some where single cones were forgotten. Will send you a complete list here tomorrow morning.

@ddavid
Copy link
Owner

ddavid commented Mar 10, 2020

Hi Sam, I've gone through the first 300 images and have the feedback contained in the following list:
2020-03-10_partial-obu-feedback.txt
All images in that range not mentioned are perfect as they are. Could you please revise the others and also apply similar changes to the remaining half I didn't go through yet?
The recurring small issues were:

  • two cones labeled as one
  • far-away cones labeled imprecisely (boxes should be tight around the cone)
  • missing labels for cones (maybe some label files got clipped?)
  • very small portions of cones labeled (e.g. one edge of the base)

For the latter, approx. half of the cone should still be visible and the type of cone should be recognizable (harder for small vs. large orange cones) which is already the case in almost all of your images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants