Fix #23: Use node20 runner instead of EOL node16 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started the tests and added you as member of the ddev org, which I think will let you restart tests as well as not have to have somebody else start them. |
rfay
previously approved these changes
Mar 7, 2024
|
No warns on https://github.com/ddev/github-action-setup-ddev/actions/runs/8184388405 vs https://github.com/ddev/github-action-setup-ddev/actions/runs/8180622047, so this is good to go IMHO. |
davereid
previously approved these changes
Mar 7, 2024
|
I actually wonder if we need to update the |
|
@davereid Good catch! Let's see if I did that correctly. |
davereid
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Use node20 runner instead of EOL node16
Manual Testing Instructions
No warns should be given.
Automated Testing Overview
See https://github.com/ddev/github-action-setup-ddev/actions/runs/8180622047. It has node 16 warnings.
This PR actions shouldn't have any.
Related Issue Link(s)
https://nodejs.org/en/blog/announcements/nodejs16-eol
Release/Deployment Notes