Fix #27: Update installation of ddev #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
reviewed
Apr 30, 2024
jonaseberle
approved these changes
May 2, 2024
|
This looks good to me and our tests are happy. I'll look at #31 and tag a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR in a GHA done with JavaScript, so please let me know if something doesn't follow the best practises.
The Issue
There is a warning on how ddev is installed, this removes this warning
Manual Testing Instructions
There is no test information, only check that there are no warning regarding installing the ddev package. If not fixed, the warning would be similar to:
Related Issue Link(s)
#27
Release/Deployment Notes
No changes needed besides merging.