Skip to content

pref/shortcuts: delay global keybinding updates until key release #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

pref/shortcuts: delay global keybinding updates until key release #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ddterm/pref/shortcuts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ function remove_shortcut(settings, model, renderer, path, accel_key = null, acce
});
}

function delay_changes(settings) {
settings.delay();
}

function apply_changes(settings) {
settings.apply();
}

export const ShortcutsWidget = GObject.registerClass({
GTypeName: 'DDTermPrefsShortcuts',
Template: ui_file_uri('prefs-shortcuts.ui'),
Expand Down Expand Up @@ -106,11 +114,30 @@ export const ShortcutsWidget = GObject.registerClass({
),
},
}, class PrefsShortcuts extends Gtk.Box {
#key_controller;

constructor(params) {
super(params);

insert_settings_actions(this, this.settings, ['shortcuts-enabled']);

if (IS_GTK3) {
this.#key_controller = Gtk.EventControllerKey.new(this);
} else {
this.#key_controller = Gtk.EventControllerKey.new();
this.add_controller(this.#key_controller);
}

this.#key_controller.connect(
'key-released',
apply_changes.bind(globalThis, this.settings)
);

this.global_accel_renderer.connect(
'accel-edited',
delay_changes.bind(globalThis, this.settings)
);

for (const renderer of [this.accel_renderer, this.global_accel_renderer]) {
for (const model of [this.shortcuts_list, this.global_shortcuts_list]) {
renderer.connect(
Expand Down
Loading