XLSX to Markdown conversion to work with XLSX files with empty Sheets.#13
Merged
dead8309 merged 1 commit intodead8309:mainfrom Jan 26, 2026
Merged
XLSX to Markdown conversion to work with XLSX files with empty Sheets.#13dead8309 merged 1 commit intodead8309:mainfrom
dead8309 merged 1 commit intodead8309:mainfrom
Conversation
Contributor
Author
|
Thanks for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XLSX to Markdown conversion to work with XLSX files with empty Sheets.
The problem
IF you tried to convert an XLSX file containing empty Sheets, following error would occur:
The fix
Check that
ws["!ref"]is defined so that the XLSX library would not fail.That said, it MAY be right to fix it somehow inside the XLSX library, BUT seeing how many un-merged PR-s the repo has, I abandoned all hope and decided to fix it inside this codebase.
Sidenotes
Thanks for the tool, nice to contribute to a OSS project with easy setup and good test coverage.