Fix PMPI_Abort in two_phase_flow/MultiPhase.#226
Merged
marcfehling merged 1 commit intodealii:masterfrom Sep 8, 2025
Merged
Conversation
26 tasks
bangerth
approved these changes
Jul 9, 2025
Member
bangerth
left a comment
bangerth
left a comment
There was a problem hiding this comment.
It seems reasonable to rebuild the preconditioner if you rebuild the matrix.
Member
|
Let's give @manuel-quezada a day or two to respond before we merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224. Related to #219.
Always rebuilding velocity preconditioners fixes the
BoomerAMGissue.However, I believe that this fix only masks the actual problem, and does not solve it. For instance, the program
TestNavierStokesworks fine.I am fine with this solution though, as I have other problems to work on and already spent a significant amount of time on this. Do you agree with this patch?
@manuel-quezada -- FYI