Performance: Improved IO operations (#43)#45
Open
vishalrao8 wants to merge 2 commits intodeansyd:masterfrom
Open
Performance: Improved IO operations (#43)#45vishalrao8 wants to merge 2 commits intodeansyd:masterfrom
vishalrao8 wants to merge 2 commits intodeansyd:masterfrom
Conversation
vishalrao8
changed the title
kingdomseed
added a commit
to kingdomseed/icloud_storage_plus
that referenced
this pull request
Mar 17, 2025
Implement I/O improvements from PR deansyd#45 (original repository): Add getContainerPath method to access the root iCloud container directory Modify download method to return a boolean success value Remove destinationFilePath parameter from download method Update documentation to reflect new API usage patterns Add examples for using the new container path access feature Update tests to match the new API signatures These improvements enhance file operations by providing direct access to the iCloud container and simplifying the download process, following Apple's guidelines for iCloud integration. Updated macOS platform channel implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Title
Improve IO performance of icloud operations. closes #43
Type of Change
Description of the Feature
downloadmethod.Implementation Details
getContainerDirectoryhas been introduced to provide root directory of local iCloud container.downloadhas been modified to return acknowledgment along with existingonProgresscallback.localFilePathargument has been removed which was used earlier to download and move files to user provided directory (Redundant step).Impact of the Feature
uploadmethod is inefficient) by providing direct access to directory of iCloud container via new method channel enabling client to directly create or manage files. Changes in root directory of local iCloud container reflects remote iCloud space.uploadmethod redundant.Testing Conducted
This PR change has been thoroughly tested and is being used in production as local package dependency.
Checklist