Skip to content

Commit

Permalink
.
Browse files Browse the repository at this point in the history
  • Loading branch information
kiyoon committed Oct 11, 2024
1 parent 5217d87 commit c0d1df9
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/build_and_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,12 @@ jobs:
matrix:
platform:
# Use the oldest version possible to maximize compatibility
- runner: macos-12
target: macosx_12_0_x86_64
- runner: macos-14
target: macosx_14_0_arm64
- runner: macos-13
target: macosx_10_12_x86_64
target_env: 10.12
- runner: macos-15
target: macosx_11_0_arm64
target_env: 11.0
steps:
- uses: actions/checkout@v4
- name: Install dependencies
Expand All @@ -75,7 +77,7 @@ jobs:
brew install gnu-sed
- name: Build app
run: |
bash build_reduce.sh ${{ inputs.reduce-release-tag }}
MACOSX_DEPLOYMENT_TARGET=${{ matrix.platform.target_env }} bash build_reduce.sh ${{ inputs.reduce-release-tag }}
- name: Build python wheel
run: |
export PATH="/Users/runner/.local/bin:$PATH"
Expand Down
11 changes: 9 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,20 @@ uv tool install build
brew install gnu-sed
```

Build the app (reduce):
Build the app at `buiid/` (reduce):

```bash
# build/
# Linux
bash build_reduce.sh v4.14
# Mac (Intel)
MACOSX_DEPLOYMENT_TARGET=10.12 bash build_reduce.sh v4.14
# Mac (Apple Silicon)
MACOSX_DEPLOYMENT_TARGET=11.0 bash build_reduce.sh v4.14
```

The `MACOSX_DEPLOYMENT_TARGET` is the cmake flag.
<https://cmake.org/cmake/help/latest/envvar/MACOSX_DEPLOYMENT_TARGET.html>

Build the wheel. It copies the `python` to `build_python/`, built binary into it, modifies the version number and builds the wheel in `build_python/dist/`.:

```bash
Expand Down
4 changes: 0 additions & 4 deletions build_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ elif [[ $# -eq 3 ]]; then

valid_platforms=("macosx_11_0_arm64" \
"macosx_10_12_x86_64" \
"macosx_12_0_x86_64" \
"macosx_13_0_x86_64" \
"macosx_14_0_arm64" \
"macosx_15_0_arm64" \
"manylinux_2_17_x86_64.manylinux2014_x86_64" \
"manylinux_2_28_x86_64" \
"manylinux_2_17_i686.manylinux2014_i686" "manylinux_2_17_aarch64.manylinux2014_aarch64" \
Expand Down

0 comments on commit c0d1df9

Please sign in to comment.