avoid to use shallow copy and it fix winstonjs#1775

debadutta98 · Oct 29, 2022 · 79c202a · 79c202a
1 parent 8769d47
commit 79c202a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/winston/create-logger.js b/lib/winston/create-logger.js
@@ -76,9 +76,10 @@ module.exports = function (opts = {}) {
       if (args.length === 1) {
         const [msg] = args;
         const info = msg && msg.message && msg || { message: msg };
-        info.level = info[LEVEL] = level;
-        self._addDefaultMeta(info);
-        self.write(info);
+        const cloneInfo = Object.assign(Object.create(info), info)
+        cloneInfo.level = cloneInfo[LEVEL] = level;
+        self._addDefaultMeta(cloneInfo);
+        self.write(cloneInfo);
         return (this || logger);
       }
 

diff --git a/test/unit/winston/logger.test.js b/test/unit/winston/logger.test.js
@@ -701,7 +701,6 @@ describe('Logger Instance', function () {
 
         const logger = helpers.createLogger(function (info) {
           assume(info).instanceOf(Error);
-          assume(info).equals(err);
           done();
         });
 
@@ -772,7 +771,6 @@ describe('Logger Instance', function () {
         const err = new Error('test');
         const logger = helpers.createLogger(function (info) {
           assume(info).instanceOf(Error);
-          assume(info).equals(err);
           done();
         });
 
@@ -959,7 +957,6 @@ describe('Logger Instance', function () {
         const err = new Error('test');
         const logger = helpers.createLogger(function (info) {
           assume(info).instanceOf(Error);
-          assume(info).equals(err);
           done();
         });