-
Notifications
You must be signed in to change notification settings - Fork 2
[FIX] 열린토론대회 토론 템플릿 데이터 변경 #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthroughsrc/constants/debate_template.ts의 DEBATE_TEMPLATE 중 TWO 섹션 내 "열린 토론대회 결승" 액션의 href 데이터 페이로드가 새로운 인코딩 문자열로 교체되었습니다. 그 외 구조, 타입, 함수, 제어 흐름 변경은 없습니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks (4 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/constants/debate_template.ts (1)
14-16: 공유 URL 생성 함수 — 슬래시 정규화 및 파라미터 명확화(옵션)BASE_URL에 슬래시가 포함된 환경도 안전하게 처리하고, 인자가 “이미 인코딩된 데이터”임을 이름으로 명확히 하길 제안합니다.
다음과 같이 소폭 정리 가능:
-function createTableShareUrl(encodeData: string): string { - return `${import.meta.env.VITE_SHARE_BASE_URL}/share?data=${encodeData}`; -} +function createTableShareUrl(encodedData: string): string { + const base = (import.meta.env.VITE_SHARE_BASE_URL || '').replace(/\/+$/, ''); + return `${base}/share?data=${encodedData}`; +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/constants/debate_template.ts(1 hunks)
🔇 Additional comments (2)
src/constants/debate_template.ts (2)
22-22: GIF 자산 변경 없음 확인
public/spinner.gif만 존재하며 이 PR에서 해당 파일이 수정되지 않았습니다. 이슈 #372의 메인 페이지 GIF 수정은 별도 PR로 처리된 것으로 보입니다.
90-93: href 페이로드 검증 완료 새 payload가 정상적으로 디코딩되었고 예상 스키마(id, info, table)와 일치합니다.
🚩 연관 이슈
closed #372
📝 작업 내용
열린토론대회 토론 템플릿 데이터 변경
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
Summary by CodeRabbit