-
Notifications
You must be signed in to change notification settings - Fork 2
[FEAT] 토론 종료 화면 동작 개선 #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a163505
feat: 시간표로 돌아가기 버튼 구현
i-meant-to-be 5288572
feat: 토론 종료 화면에 시간으로 돌아가기 버튼 추가
i-meant-to-be 78dc924
feat: 토론 종료 화면으로 돌아가기 버튼 구현
i-meant-to-be 824ee2a
feat: 피드백 타이머에 돌아가기 버튼 추가
i-meant-to-be ff2f32d
feat: 투표 URL이 테이블 ID도 표기하도록 수정
i-meant-to-be 00a8f5d
feat: URL 변경 사항 관련 페이지에 반영
i-meant-to-be 955a9ea
refactor: 버튼들이 `className` 받을 수 있게 개선
i-meant-to-be 9a3509b
refactor: 버튼 변경 사항 반영
i-meant-to-be e02980b
fix: 불필요한 배경색 삭제
i-meant-to-be 69e5de4
chore: 더 이상 사용되지 않는 파일 삭제
i-meant-to-be f54fe1b
design: 써니 의견에 따라 아이콘 변경
i-meant-to-be 7eed4ec
fix: 라우팅 테이블과 실제 페이지 간 경로 다른 문제 수정
i-meant-to-be b9ec785
refactor: 테이블 ID 검증 로직 보강
i-meant-to-be 078c181
fix: 쿼리 실행 조건 수정
i-meant-to-be 645effb
fix: 매개변수 이름 수정
i-meant-to-be a1cfe4a
fix: VoteDetailResult 모달에서 버튼이 제대로 눌리지 않는 문제 수정
i-meant-to-be bfe1710
fix: 핸들링 함수 중첩되어 사용된 문제 수정
i-meant-to-be 25a0595
design: 뒤로 가기 버튼 화살표 방향 수정
i-meant-to-be ff17288
feat: 투표 결과 화면에 토론 종료 화면으로 돌아가기 버튼 추가
i-meant-to-be bef54e0
design: 버튼 위치 시안에 맞게 변경
i-meant-to-be 521721b
feat: 투표 세부 결과 페이지에 확인 모달 추가
i-meant-to-be 0a67d6d
refactor: 투표 결과 화면 스타일 태그 일부 수정
i-meant-to-be 55bba16
fix: `tableId` 잘못 기입되어 있던 문제 수정
i-meant-to-be 235c0dc
Merge branch 'develop' into feat/#400
i-meant-to-be 7ebf328
feat: 투표 결과 화면 뒤로 가기 버튼이 뒤로 가도록 변경
i-meant-to-be c5a1c06
fix: 불필요한 참조 제거
i-meant-to-be File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
src/components/GoToDebateEndButton/GoToDebateEndButton.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import clsx from 'clsx'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
|
|
||
| interface GoToDebateEndButtonProps { | ||
| tableId: number; | ||
| className?: string; | ||
| } | ||
|
|
||
| export default function GoToDebateEndButton({ | ||
| tableId, | ||
| className = '', | ||
| }: GoToDebateEndButtonProps) { | ||
| const navigate = useNavigate(); | ||
| const handleClick = (tableId: number) => { | ||
| navigate(`/table/customize/${tableId}/end`); | ||
| }; | ||
|
|
||
| return ( | ||
| <button | ||
| type="button" | ||
| aria-label="토론 종료 화면으로 돌아가기" | ||
| onClick={() => handleClick(tableId)} | ||
| className={clsx( | ||
| 'button enabled neutral flex flex-row rounded-full p-[24px]', | ||
| className, | ||
| )} | ||
| > | ||
| 뒤로 가기 ← | ||
| </button> | ||
| ); | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import clsx from 'clsx'; | ||
| import { RiCalendarScheduleLine } from 'react-icons/ri'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
|
|
||
| interface GoToOverviewButtonProps { | ||
| tableId: number; | ||
| className?: string; | ||
| } | ||
|
|
||
| export default function GoToOverviewButton({ | ||
| tableId, | ||
| className = '', | ||
| }: GoToOverviewButtonProps) { | ||
| const navigate = useNavigate(); | ||
| const handleClick = (tableId: number) => { | ||
| navigate(`/overview/customize/${tableId}`); | ||
| }; | ||
|
|
||
| return ( | ||
| <button | ||
| type="button" | ||
| aria-label="시간표로 돌아가기" | ||
| onClick={() => handleClick(tableId)} | ||
| className={clsx( | ||
| 'button enabled neutral flex flex-row space-x-2 rounded-full p-[24px]', | ||
| className, | ||
| )} | ||
| > | ||
| <RiCalendarScheduleLine className="aspect-square h-full" /> | ||
| <p>시간표로 돌아가기</p> | ||
| </button> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.