Skip to content

[HOTFIX] 고려대학교 FECD 토론 템플릿 추가 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
useon merged 1 commit into from
Feb 15, 2026
Merged

[HOTFIX] 고려대학교 FECD 토론 템플릿 추가 #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 src/assets/template_logo/kogito.png → src/assets/template_logo/korea.png
View file
Open in desktop
File renamed without changes
17 changes: 15 additions & 2 deletions src/constants/debate_template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import hantomak from '../assets/template_logo/hantomak.png';
import seobangjeongto from '../assets/template_logo/seobangjeongto.png';
import osansi from '../assets/template_logo/osansi.png';
import nogotte from '../assets/template_logo/nogotte.png';
import kogito from '../assets/template_logo/kogito.png';
import korea from '../assets/template_logo/korea.png';
import mcu from '../assets/template_logo/mcu.png';
import ylt from '../assets/template_logo/yuppm_law_track.png';
import { DebateTemplate } from '../type/type';
Expand Down Expand Up @@ -87,6 +87,19 @@ export const DEBATE_TEMPLATE: DebateTemplateList = {
},
],
},
{
title: 'FEDC',
subtitle: '고려대',
logoSrc: korea,
Comment on lines +91 to +93
Copy link

@gemini-code-assist gemini-code-assist bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

고려대학교 관련 템플릿('FEDC', '코기토')에서 subtitle과 logoSrc가 중복되고 있습니다. 유지보수성을 높이기 위해, 중복되는 속성을 공통 상수로 추출하는 것을 고려해 보세요. 이렇게 하면 향후 고려대학교 관련 템플릿을 추가하거나 수정할 때 일관성을 유지하기 쉽습니다.

예시:

const KOREA_UNIVERSITY_PROPS = {
  subtitle: '고려대',
  logoSrc: korea,
};

// DEBATE_TEMPLATE 정의에서 사용
{
  title: 'FEDC',
  ...KOREA_UNIVERSITY_PROPS,
  actions: [/* ... */],
},
// ...
{
  title: '코기토',
  ...KOREA_UNIVERSITY_PROPS,
  actions: [/* ... */],
}

actions: [
{
label: 'FEDC 토론',
href: createTableShareUrl(
'eJzVlr9PwkAUx%2F%2BV5ganmiBGo90ESmIiLeHHoiHmgAMay7WhEDWEhAFcdNBEjENDqkYnhhqjceAvouf%2F4B1FQgwUwyBl633be%2Fd537z3rnWg5IGwFdzlgYILGhDqAMMyAgKIipEw93VhOQ8W4EH1XGdiOJ1MybH9Q5FKsIhwHlKRPusVzUghWJbcvcTukdYr1XMantQd%2B965alL9FFawgoshpKpAKEDVQDwoKFgxShNSgx4LsyrdeFQHRhXiHIsRT8hJGsHQEcqVUi4W6bZdzKx2NpIkORHbO2DkCjt6Ixigb4exabBRNiExKifEY1GKjL8LMOYargIh2Mi4YhxVWApAwDVVHUtJHcETmsKPbLA1qjA7GvwEbliWVglXEtOpxBDkF%2FENsVocuTQHdssLfPu%2FuNnyj0ZzrOzsjqffO0vye3Y1j6jXSLc3n38z4KPydnEHb32OPPVJ99mX4NOMXwnwmR16TUxrPK89GtRXHcos9wb2XYXMmdzLmiSLubu0i2ZBd311jX%2FcDuym23LrPmafesesCPusafdukse2Y5vk7pMjVsd56a3cv8kwBc7NwZfeT60bX1JnGt%2BsKGJW',
Copy link

@gemini-code-assist gemini-code-assist bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

템플릿 데이터가 인코딩된 긴 문자열로 하드코딩되어 있어 가독성과 유지보수성이 떨어집니다. 데이터의 원본 형태(객체)를 상수로 정의하고, createTableShareUrl 함수로 전달할 때 인코딩하는 방식으로 리팩터링하는 것을 고려해 보세요. 이렇게 하면 데이터 구조를 파악하기 쉽고, 수정이 필요할 때 훨씬 용이합니다.

),
},
],
},
Comment on lines +90 to +102
Copy link

@coderabbitai coderabbitai bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

오타: '고리대' → '고려대'

Line 92의 subtitle이 '고리대'로 되어 있습니다. 고려대학교를 의미하는 '고려대'가 맞습니다. 같은 파일 Line 292의 코기토 항목에서는 '고려대'로 올바르게 표기되어 있습니다.

🔧 수정 제안 
     {
       title: 'FEDC',
-      subtitle: '고리대',
+      subtitle: '고려대',
       logoSrc: korea,
🤖 Prompt for AI Agents 
In `@src/constants/debate_template.ts` around lines 90 - 102, The object with
title 'FEDC' has a typo in the subtitle property ('고리대'); update the subtitle
value to '고려대' in the debate template object (the entry whose title is 'FEDC'
with logoSrc korea and actions array) to match the correct university name; also
scan the same file for any other occurrences to ensure consistency (e.g., the
cogito entry already uses '고려대').

],
TWO: [
{
Expand Down Expand Up @@ -277,7 +290,7 @@ export const DEBATE_TEMPLATE: DebateTemplateList = {
{
title: '코기토',
subtitle: '고려대',
logoSrc: kogito,
logoSrc: korea,
actions: [
{
label: '2:2 일반토론대회 형식',
Expand Down
Loading