DBZ-8301 Support for decimal.handling.mode

[jpechane]

https://issues.redhat.com/browse/DBZ-8301

[github-actions]

Hi @jpechane. Thank you for your valuable contribution.
Please author your commit(s) using an email linked to your GitHub account.

[github-actions]

Welcome as a new contributor to Debezium, @jpechane. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

[jpechane]

@aziza-calm Would it be possible to add a test to verifythe behaviour?

[aziza-calm]

@aziza-calm Would it be possible to add a test to verifythe behaviour?

sorry for maybe silly question, but should I first clone your forked copy of repo, and add test there?

[jpechane]

No, Isuppose you have a fork repo of this one. So you should just add another class side- by-side with As400ConnectorIT.
The class should have three methods. The test tbale should contain at least one decimal column. Each test method will test a different mode and verify that the schema of the message is of the expected schema type and the value is of the expected Java type and value.

[aziza-calm]

No, Isuppose you have a fork repo of this one. So you should just add another class side- by-side with As400ConnectorIT. The class should have three methods. The test tbale should contain at least one decimal column. Each test method will test a different mode and verify that the schema of the message is of the expected schema type and the value is of the expected Java type and value.

I do have a fork repo, and I did some changes on it before I noticed that my PR was closed. How to put those changes in new 2 PRs?

[jpechane]

You should be able to just cherry-pick the commits you need to apply to the new branches/PRs

[msillence]

should we delete the decault constructor? It doesn't look like it's used anywhere else

[msillence]

Can I just check - does this doesn't change existing default behaviour or require changes to existing config?

[github-actions]

Hi @jpechane. Thank you for your valuable contribution.
Please author your commit(s) using an email linked to your GitHub account.

[jpechane]

@msillence No, there is no change to the default behaviour.
Construtor removed

[msillence]

great, thanks, fine by me

[msillence]

looks good