Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translations #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Chinese translations #38

wants to merge 2 commits into from

Conversation

qftgtr
Copy link

@qftgtr qftgtr commented Mar 24, 2019

The Chinese translation for talkyard.

@qftgtr qftgtr changed the title [WIP] Add Chinese translations Add Chinese translations Apr 3, 2019
@kajmagnus
Copy link
Collaborator

kajmagnus commented Apr 21, 2019

Hi Zehao @qftgtr,

Ok so I've recently added even more translation values. I'm thinking maybe it'd be annoying for you, to keep up with the textual changes I'm doing every now and then? (I mean, you'd need to submit new PRs every now and then, to update the Chinese translations.)

What about this: If you squash the commits, and sign the CLA (by editing the commit message), then, some time later I can merge the PR, and then I can find a freelancer at e.g. Upwork, who speaks Chinese, and does the small remaining and re-occurring work, with updating the Chinese translation, whenever I change text messages and button titles?

(Probably the Chinese translation, and all other translations, from time to time will be a bit out of date. It'd take a while, after I change some texts / button titles, until I had time to contact the translator(s). )

@kajmagnus
Copy link
Collaborator

kajmagnus commented Mar 29, 2020

Hi again Phil, @qftgtr , what if you type here that you agree to the CLA? I.e. this file:
https://github.com/debiki/talkyard/blob/master/docs/CLA-v2.txt

Then I can include this Chinese translation in Talkyard.

Sorry I didn't think of a more light weight approach for agreeing to the CLA and adding new translations before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants