Fix: Allow cycles parameter to accept 0 to disable auto-switching
#155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Allow
cyclesparameter to accept0to disable auto-switchingProblem
The dashboard frontend currently parses the
cyclesinput value using:This causes
0to be treated as falsy, defaulting to10instead of being accepted as a valid value.Solution
Use the nullish coalescing operator to properly handle
0:Backend Compatibility
The switcher script already supports
0to skip refreshing:Use Case
When displaying static dashboards (e.g., Grafana), disabling the xiosk-switcher service gets overridden on configuration updates. Setting
cycles=0provides a cleaner way to disable auto-switching without stopping the service.Related to #63