This repository was archived by the owner on Aug 19, 2025. It is now read-only.
server: log on missing handler#26
Merged
decathorpe merged 3 commits intodecathorpe:mainfrom Feb 28, 2025
Merged
Conversation
decathorpe
suggested changes
Feb 27, 2025
Owner
decathorpe
left a comment
decathorpe
left a comment
There was a problem hiding this comment.
Thank you for your contribution, I think this makes a lot of sense, especially for development or debugging purposes! I left some comments.
Contributor
Author
|
Thanks for your feedback. I adjusted my code accordingly. |
Owner
|
Great, thanks! Looks good to me. I'll let the CI run and merge assuming everything is green. Would it help you if I published this as a new release to crates.io? |
Contributor
Author
|
Great. I'm not in a hurry. So don't do the release just for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
first of all thank you for creating and maintaining this very helpful project!
This PR adds a log message to dxr_server on unhandled method calls.
I used the rust standard log crate for that purpose. It's also used for example in reqwest so it's already in the dependency tree.
I find those logs very useful when working with the server and a not fully known counterpart.
Thank you in advance for checking the PR!