Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

deps: upgrade axum to 0.8#27

Closed
taliaferro wants to merge 3 commits intodecathorpe:mainfrom
taliaferro:main
Closed

deps: upgrade axum to 0.8#27
taliaferro wants to merge 3 commits intodecathorpe:mainfrom
taliaferro:main

Conversation

@taliaferro
Copy link

@taliaferro taliaferro commented Apr 10, 2025

This PR upgrades the Axum dependency to 0.8 to take advantage of new features in axum -- chiefly, the ability to listen on anything that implements axum::serve::Listener, instead of only TCP ports. This makes it possible to bind the server to a local Unix domain socket, like so:

// set up server as shown in example code
let socket_path = "/var/run/myapp/server.sock";
let socket_listener = tokio::net::UnixListener::bind(&socket_path)?;
server.serve_listener(socket_listener).await?;

Copy link
Owner

@decathorpe decathorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two quick comments for things I noticed immediately. Will take another look tomorrow.

@decathorpe
Copy link
Owner

Thanks, the changes look good to me now. However, axum 0.8 seems to have bumped its own MSRV to 1.75, which is newer than the currently documented one of 1.70. Raising it is not a problem, I'll do that, rebase your PR, and re-run the CI ... hopefully all should be green then.

@decathorpe
Copy link
Owner

I pushed changes to raise the MSRV to 1.75, this should unblock the axum update here. But it looks like I can't rebase your PR myself.

@Hate9
Copy link

Hate9 commented Jul 27, 2025

@taliaferro I'd love to see this merged - what else is still needed to rebase and merge this?

@decathorpe
Copy link
Owner

@Hate9 I was waiting for this PR to be rebased against current git main to pick up the fixed / updated CI settings.

But given that this has been sitting around for a few months without that happening, I'll make the axum v0.8 changes myself.

Note that this will only land in dxr v0.8.0 (i.e. the next major release) since axum is part of the public API, and I still want to make some breaking changes before I publish 0.8.0, so it will not happen immediately :)

@decathorpe decathorpe closed this Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants