This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Feature: Add Basic Authentication Support#28
Merged
decathorpe merged 2 commits intodecathorpe:mainfrom Apr 17, 2025
AH-dark:feat/basic-auth
Merged
Feature: Add Basic Authentication Support#28decathorpe merged 2 commits intodecathorpe:mainfrom AH-dark:feat/basic-auth
decathorpe merged 2 commits intodecathorpe:mainfrom
AH-dark:feat/basic-auth
Conversation
Owner
|
Thanks for your PR! I'm not sure if I actually want the builtin reqwest client to grow more featureful. Both the reqwest client and the axum server are intended to be minimal "getting started" implementations. Though I suppose this is a very simple feature to add since it just adds a few lines of code ... There are some potential issues with the code that I see, I'll leave those as inline reviews. |
decathorpe
suggested changes
Apr 14, 2025
…asic_auth` constructor, use `self.password.as_ref()`
decathorpe
approved these changes
Apr 17, 2025
Owner
|
Thank you, looks good to me now! Do you need a new release with these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for HTTP Basic Authentication in the
ClientBuilderandClientstructures of thedxr_clientcrate.It allows users to connect to XML-RPC endpoints that require a
usernameandpassword, without manually customizing the underlyingreqwest::Client.What's Changed
usernameandpasswordfields toClientBuilderandClient.Motivation
Some enterprise or internal XML-RPC APIs are protected with Basic HTTP Authentication. This patch provides first-class support to enable seamless integration with such systems.