feat: errors for no existing world or failing permissions#1361
Open
alejandralevy wants to merge 4 commits intomainfrom
Open
feat: errors for no existing world or failing permissions#1361alejandralevy wants to merge 4 commits intomainfrom
alejandralevy wants to merge 4 commits intomainfrom
Conversation
Contributor
Test this pull request
|
RocioCM
requested changes
Mar 25, 2026
Comment on lines
+362
to
+367
| export async function validateWorldExists(worldName: string, targetContent: string): Promise<boolean> { | ||
| const encodedName = encodeURIComponent(worldName) | ||
| const url = `${targetContent}/world/${encodedName}/about` | ||
| const response = await fetch(url) | ||
| return response.ok | ||
| } |
Member
There was a problem hiding this comment.
If an existing world has no scenes deployed, /about returns 404, this may break deployments to existing empty worlds 🙃
Contributor
Author
There was a problem hiding this comment.
oh nice catch roooo! so I guess we might not check that case
| const permissions = await fetchWorldPermissions(worldName, targetContent) | ||
| const lowerAddress = address.toLowerCase() | ||
|
|
||
| logger.info(`[DEPLOY] Permissions response for "${worldName}": ${JSON.stringify(permissions)}`) |
Member
There was a problem hiding this comment.
The logs on this file are for debugging or should be kept?
Deploying js-sdk-toolchain with
|
| Latest commit: |
9ee2150
|
| Status: | 🚫 Build failed. |
alejandralevy
force-pushed
the
feat/deploy-error-handling
branch
from
016aa87 to
9ee2150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling on deployments
GET /api/world-parcel-permissions/:addressendpoint for the linker-dapp to fetch parcel permissions after wallet connectionRelated linker-dapp PR: decentraland/linker-dapp#49
Cases
World deploy with full permissions (non-multi-scene)
npm run deploy -- --target-content https://worlds-content-server.decentraland.zoneWorld deploy non-multi-scene without world-wide permission
npm run deploy -- --target-content https://worlds-content-server.decentraland.zoneWorld deploy with partial parcel permissions (multi-scene)
npm run deploy -- --target-content https://worlds-content-server.decentraland.zone --multi-sceneWorld deploy with NO permissions
npm run deploy -- --target-content https://worlds-content-server.decentraland.zone --multi-sceneWorld deploy non-multi-scene with existing scenes on other parcels
npm run deploy -- --target-content https://worlds-content-server.decentraland.zone