Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk ui enter-leave pointer events #2907

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Nov 27, 2024

Added support for UI onMouseEnter and onMouseEnter events.

Issue: decentraland/creator-hub#174

Related PR:


QA TEST STEPS

  1. Download the build from this PR and open it
  2. Go to 65,-125 scene
  3. Confirm that every time you put the mouse over the "hover area", its background color changes
  4. Confirm that the same happens when you move the mouse outside that same area
Screen.Recording.2024-12-13.at.7.06.23.PM.mp4

@pravusjif pravusjif added the sdk label Nov 27, 2024
@pravusjif pravusjif self-assigned this Nov 27, 2024
@pravusjif pravusjif added the force-build Used to trigger a build on draft PR label Nov 27, 2024
@pravusjif pravusjif marked this pull request as ready for review December 13, 2024 18:14
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved:
Tested on Mac and Windows. The background color changes correctly when hovering over the area and reverts when moving the mouse out. Everything works as expected. ✅

2907.mp4

Smoke test performed:

  • Quest completition
  • Social Interaction (chat, emote sync)
  • World: Metadynelabs, Juliasgift, Pravus
  • Scene visited: Casa Roustan, Game Expo, DCLMF24, Doll House
  • Backpack functionality

@pravusjif pravusjif merged commit b2125f6 into dev Dec 16, 2024
9 checks passed
@pravusjif pravusjif deleted the feat/sdk-ui-enter-leave-pointer-events branch December 16, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force-build Used to trigger a build on draft PR sdk
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants