Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ES256 to JWT.ts #254

Merged
merged 71 commits into from
Oct 15, 2022
Merged

Add ES256 to JWT.ts #254

merged 71 commits into from
Oct 15, 2022

Conversation

bshambaugh
Copy link
Contributor

This is a work in progress. This should look like the final form. (ignore VerifierAlgorithm.ts and VerifierAlgorithm.test.ts because it was modified in the previous PR). I'm on the road, so I will update this when I find better internet

@bshambaugh
add ES256Signer Module
aaedaf5
@bshambaugh
update base58 test, it appears to have a problem
ae80a5a
@bshambaugh
update with failing test for base58
52646fd
@bshambaugh
modify base58matcher to match both base58 in es256 and es256k
ac8e814
@bshambaugh
change 68 to 86 in base58 matcher
27fd5ea
@bshambaugh
remove uneccessary = sign in the base64 regex
3835342
@bshambaugh
add ES256Signer to index so it is acessible
7c26c1a
@bshambaugh
refactor SignerAlgorithm.ts and SignerAlgorithm.test.ts by breaking u…
333fa55 
…p into files by curve
@bshambaugh
move tests for signers into folder called signers
f9ed034
@bshambaugh
remove carriage returns (should be result of enter) and unused variab…
85a5cbc 
…les as suggested by linter
@bshambaugh
break up verifierAlgorithm into separate files bases on Curve
ac795f0
@bshambaugh
add preliminary tests for JWT
9d108ad
@bshambaugh
refactor VerifierAlgorithm test
635eb7e
@bshambaugh
update JWT tests
622a7d1
@bshambaugh
update ES256Signer with constants
62e6f7d
@bshambaugh
change the name of constants to common in JWT test folder
dcdeeb5
@bshambaugh
add tests for JWT common
e498f41
@bshambaugh
add ES256 to Signer Verifier and JWT ...tests needed
d8dccf9
@bshambaugh
add note about supported key types in JWT, Signer, and Verifier Algor…
61e9928 
…ithms, add a not for secp256r1 support of in src/VerifierAlgorithm.common.ts
@bshambaugh
in common_Signer_test_test.ts the create JWK functions need to be tes…
20c1ebe 
…ted for u8a, temporarily commiting for now
@bshambaugh
added test to for comosmos adress from public key to keep consistent …
8b18d4e 
…through changes
@bshambaugh
commit stub for decrypt / encrypt JWE Decrypter impl. for P-256
0c1c1fd
@bshambaugh
reverse base64matcher to original version that will match '=' sign, o…
f312794 
…pen up issue
@bshambaugh
add a second matcher for base58 to util.test.ts to illustrate variabl…
8a38d4c 
…e length issue
@bshambaugh
remove encrypters and clean up to remote forks state
027f701
@bshambaugh
update util.ts with latest matcher
f39c88e
@bshambaugh
util.ts to fork
92e2bff
@bshambaugh
util.ts to fork try 2
6dcb134
@bshambaugh
reset util.test.ts to fork
9c0b48b
@bshambaugh
remove cosmos test because it is not upstream
a0cd2a2
@bshambaugh
Add ES256Signer Tests
4e0a669
@bshambaugh
update fixes suggested by linter
5b0cecf
@bshambaugh
removed recoverable parameter from ES256Signer since only recoverable…
169e7bd 
… with secp256k1 not secp256r1
@bshambaugh
add code specific to ES256 and P-256 to SignerAlgorithm.ts
7b02c56
@bshambaugh
created files for verifieralgorithm.ts, tests do not pass..merge with…
636de24 
… signer alg code
@bshambaugh
Merge branch 'addES256VerifierAlg' into addES256SignerandVeriferAlg
b06fca3
@bshambaugh
move signer declaration to match interface
3a4e4bc
@bshambaugh
fix merge conflict with ES256Signer and test
c789049
@bshambaugh
Merge branch 'master' into addES256SignerandVeriferAlg
e8b46a2
@bshambaugh
update verifieralgorithm and tests with ES256
d73bd52
@bshambaugh
Merge branch 'master' of github.com:bshambaugh/did-jwt
c7ab289
@bshambaugh
add tests to JWT for ES256
de5fc43
@bshambaugh
temporarily comment out failing tests
c74f938
@bshambaugh
create backup __tests__/JWT.test.ts
8938a0d
@bshambaugh
add comments to ES256K code
a7d99f9
@bshambaugh
start redo of tests to JWT.test.ts
b68692d
@bshambaugh
updated JWT.test.ts to update with ES256
29e587d
@bshambaugh
update JWT.test.ts have ES256
8291c73
@bshambaugh
update with typescript types and move to dev for jwkToPem and jsonweb…
f22a7b1 
…token in package.json
@bshambaugh
Pull in remote did-jwt to keep VerifierAlgorithm
c54b109
@bshambaugh
Copy link
Contributor Author

@mirceanis , at least this seems reasonable. I did not have all of the tests that ES256K had since I did not have a recoverySigner and some tests seemed a bit more general like testing for multiple publicKeys so I did not include them.

mirceanis
mirceanis requested changes Oct 8, 2022
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Thanks for this submission.
Please see my comment about EcdsaSecp256r1VerificationKey2022 and remove package-lock.json

src/JWT.ts Outdated Show resolved Hide resolved
mirceanis
mirceanis requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, the last thing to be done is to remove the package-lock.json file as we already use yarn.lock and having 2 such files can lead to undefined behavior.

@bshambaugh
Copy link
Contributor Author

bshambaugh commented Oct 14, 2022 •
edited
Loading

This PR looks good, the last thing to be done is to remove the package-lock.json file as we already use yarn.lock and having 2 such files can lead to undefined behavior.

I think package-lock.json should be gone now.

@mirceanis mirceanis merged commit 86a4d23 into decentralized-identity:master Oct 15, 2022
uport-automation-bot pushed a commit that referenced this pull request Oct 15, 2022
@semantic-release-bot
chore(release): 6.9.0 [skip ci]
227fe98 
# [6.9.0](6.8.0...6.9.0) (2022-10-15)

### Features

* add ES256 to JWT verifier ([#254](#254)) ([86a4d23](86a4d23))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 6.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshambaugh @uport-automation-bot @mirceanis