Clarifications about TLS Names and ABNF of ports #122
Conversation
Signed-off-by: Stephen Curran <swcurran@gmail.com>
spec/specification.md
Outdated
| domain-segment = ; A part of a domain name as defined in RFC3986, such as "example" and "com" in "example.com" | ||
| percent-encoded-port = "%3A" ( "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9" ) 1*3( "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9" ) |
There was a problem hiding this comment.
I think it should be 1*4 here as ports can go up to five digits. Also there's a commonly used ABNF primitive called "DIGIT" you can use instead of listing all the values.
So its something like ["%3A" 1*5(DIGIT)] should be fine if you'd rather do that.
There was a problem hiding this comment.
I was being picky :-). The port (AFAIK) can’t have a leading 0 and “00000” can’t be used, hence the extra.
I didn’t know about 5 digit ports, but I guess that is obvious — 0 - 64k. So there you go.
Updating to: percent-encoded-port = "%3A" ( "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9" ) 1*4( DIGIT )
What do you think?
There was a problem hiding this comment.
Updated. Realized at the same time that the scid component was missing.
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Addresses PRs #110 and #111.
Please review carefully the ABNF -- I think I have it right, but could use a second set of eyes on it.
@daidoji and @andrewwhitehead (and anyone else expert in ABNF).
Signed-off-by: Stephen Curran swcurran@gmail.com