Update setup.py #37
Merged
Update setup.py #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change packages required for install
|
Sorry for the confusion. This should be the right pull request. Please approve so people can install submodlib via pip as described in you readme |
|
@krishnatejakk @vishkaush Please approve this. cant really checkout the examples if not fixed. |
vishkaush
reviewed
Mar 30, 2023
|
I have tried it out locally and for me it works perfectly fine. If you are unsure, then feel free to test it out on your machine, too. It's only one line in the setup file, so nothing crazy @vishkaush |
vishkaush
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change packages required for install as proposed in #35