Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer receivers for unsafeset #143

Merged

Conversation

ryclarke
Copy link
Contributor

@ryclarke ryclarke commented Aug 7, 2024

Resolves #122
Unit tests have been added to confirm this based on the provided examples.
Also includes examples of unmarshaling a struct with a Set property, as well as a Set of (comparable) structs.

@costela
Copy link

costela commented Dec 3, 2024

@deckarep any chance we can get this reviewed? 😇 🙏

@deckarep deckarep merged commit e00dc23 into deckarep:main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmarshalling threadUnsafeSet with json.Unmarshal panics
3 participants