Prepare for 0.3 release #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** - Add a default PREFIX_LEN to all iterator types with a value of 16 - Remove most instances of `*Keys`, `*Values`, `*ValuesMut` iterators - Rename the tree iterators to match the `std::collection::BTreeMap` ones - Add `#[non_exhaustive]` to the well-formed visitor error type **Motivation** - Adding a default `PREFIX_LEN` biases towards making it easy to provide a type for the iterators in the common case, without the user ever needing to learn about the prefix or what the default length is. - I don't really like all the extra iterators, and I'm only keeping the remaining ones because `BTreeMap` has them - I also wanted to match the tree iterators names to have the same as in the stdlib, making it easier to drop-in replace using this crate - Adding `#[non_exhaustive]` makes future additions to the enum non-breaking changes **Testing Done** `./scripts/full-test.sh nightly`
**Description** Add tests and unsafe impls to ensure that the `TreeMap` and related types are `Send` and `Sync`. **Motivation** This is needed to match the interface of the `BTreeMap` and to make sure we don't regress on this behavior between releases. The `unsafe impl`s are not my favorite way to implement this, I would have preferred that the building block types were naturally `Send` or `Sync`, that wasn't easily done. Maybe a future improvement to remove those. **Testing Done** `./scripts/full-test.sh nightly`
declanvk
force-pushed
the
prepare-0.3
branch
from
6bb4dc2 to
1bdd4cb
Compare
declanvk
force-pushed
the
prepare-0.3
branch
from
59e0b2a to
61f1a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.