Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable img optimization for all image providers #982

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matheusgr
Copy link
Contributor

What is this Contribution About?

Please provide a brief description of the changes or enhancements you are proposing in this pull request.

Issue Link

Please link to the relevant issue that this pull request addresses:

Loom Video

Record a quick screencast describing your changes to help the team understand and review your contribution. This will greatly assist in the review process.

Demonstration Link

Provide a link to a branch or environment where this pull request can be tested and seen in action.

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.64.12 update
  • 🎉 for Minor 0.65.0 update
  • 🚀 for Major 1.0.0 update

Copy link
Contributor

@igorbrasileiro igorbrasileiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +95 to +100
originalSrc.startsWith(
"https://ozksgdmyrqcxcwhnbepg.supabase.co/storage",
) ||
originalSrc.startsWith(
"https://deco-sites-assets.s3.sa-east-1.amazonaws.com/",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt about this snippet:

const ALLOWED_ORIGINS = ["https://ozksgdmyrqcxcwhnbepg.supabase.co/storage",  "https://deco-sites-assets.s3.sa-east-1.amazonaws.com/"]
Suggested change
originalSrc.startsWith(
"https://ozksgdmyrqcxcwhnbepg.supabase.co/storage",
) ||
originalSrc.startsWith(
"https://deco-sites-assets.s3.sa-east-1.amazonaws.com/",
)
ALLOWED_ORIGINS.some(origin => originalSrc.startsWith(origin))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants