Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: Make block index flushable. #1375

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jul 25, 2018

This PR depends on #1367.

This modifies the block index to support tracking modified nodes and flushing them to the database. This ensures that validation states set on arbitrary nodes are persisted to the database and helps pave the way towards supporting decoupling the chain processing logic from the download logic.

In the immediate term, as of this commit, side chains which encounter an invalid block will no longer potentially have to be revalidated to discover they are invalid after restart.

A few comments are also improved while here.

This is work towards #1145.

@davecgh davecgh added this to the 1.3.0 milestone Jul 25, 2018
@davecgh davecgh mentioned this pull request Jul 25, 2018
33 tasks
@davecgh davecgh force-pushed the blockchain_flushable_blockindex branch 2 times, most recently from 68c6458 to 18b7c1a Compare July 25, 2018 08:42
Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok testnet2 miner

This modifies the block index to support tracking modified nodes and
flushing them to the database.  This ensures that validation states set
on arbitrary nodes are persisted to the database and helps pave the way
towards supporting decoupling the chain processing logic from the
download logic.

In the immediate term, as of this commit, side chains which encounter an
invalid block will no longer potentially have to be revalidated to
discover they are invalid after restart.

A few comments are also improved while here.
@davecgh davecgh force-pushed the blockchain_flushable_blockindex branch from 18b7c1a to b968b40 Compare July 26, 2018 20:52
@davecgh davecgh merged commit b968b40 into decred:master Jul 26, 2018
@davecgh davecgh deleted the blockchain_flushable_blockindex branch July 26, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants