Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: Remove easiest diff checkpoint checks. #2012

Merged

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Nov 27, 2019

This requires PR #2008.

These checks are no longer necessary since they applied to orphans and blockchain no longer handles orphans. Further, orphans are currently otherwise limited by the block manager and this is another step towards the overall effort to decouple the connection code from the download logic. Ultimately, the goal is to remove orphan handling altogether.

Finally, it also has the added benefit of further minimizing the reliance on trusted known good checkpoints.

@davecgh davecgh added this to the 1.6.0 milestone Nov 27, 2019
These checks are no longer necessary since they applied to orphans and
blockchain no longer handles orphans.  Further, orphans are currently
otherwise limited by the block manager and this is another step towards
the overall effort to decouple the connection code from the download
logic.  Ultimately, the goal is to remove orphan handling altogether.

Finally, it also has the added benefit of further minimizing the
reliance on trusted known good checkpoints.
@davecgh davecgh force-pushed the blockchain_remove_easiest_diff_checks branch from 0092697 to 7fd7f7b Compare December 6, 2019 03:44
@davecgh davecgh merged commit 7fd7f7b into decred:master Dec 6, 2019
@davecgh davecgh deleted the blockchain_remove_easiest_diff_checks branch December 6, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants