Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -n to test for bash script argument #1988

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ukane-philemon
Copy link
Collaborator

./run_tests.sh fails on my Mac.

Error message: ./run_tests.sh: line 16: conditional binary operator expected.

% bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin22)
Copyright (C) 2007 Free Software Foundation, Inc.

This PR uses a stable conditional expression -n to test for bash script argument in ./run_tests.sh.

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but... 2007 warez?

@chappjc chappjc merged commit 6fe8861 into decred:master Jun 5, 2024
5 checks passed
@jrick
Copy link
Member

jrick commented Jun 6, 2024

Ok, but... 2007 warez?

it's stuck on the last gpl2 release. apple won't upgrade it past that to a gpl3 version.

they also changed the default shell to zsh (which is MIT licensed fwiw).

@chappjc
Copy link
Member

chappjc commented Jun 6, 2024

Get your brew on then

@ukane-philemon
Copy link
Collaborator Author

Get your brew on then

I've got brew, but I only use it for third-party software that doesn't come packaged 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants