{cmd/dcrdata}: Use template func for footer year #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Sep 22, 2024
Merged
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
force-pushed
the
go-year
branch
from
8a316f9
to
8ee9af9
Compare
davecgh
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Code looks fine now, so approved.
That said, it's arguable whether or not this should be automatic. After all, if nobody from the Decred project touched the code in the current year, the copyright shouldn't really be updated to claim that they have.
On the other hand, in practice, at least one of the files somewhere is very likely to have been modified and it's exceedingly easy to forgot updating this off in some file nested down in a cmd subdir, so it is nice from that perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
currentYeartemplate function to display the correct current year so we don't need to update this every year.