internal: Add basic simnet xmr swap. #2885
Conversation
JoeGruffins
force-pushed
the
xmrscripts
branch
5 times, most recently
from
815ed6c
to
7076e42
Compare
JoeGruffins
force-pushed
the
xmrscripts
branch
7 times, most recently
from
d60bc68
to
bb8eedc
Compare
There was a problem hiding this comment.
I've tested the swap and it works, but the code is a bit hard to understand. I think it would be better if there were two separate clients, initiatorClient and participantClient each with just the functions that they perform. Then, these functions could take as arguments types such as genKeysMsg, genLockTxMsg, etc. which would be equivalent to the communication that would take place when the trade is being done in the dex.
| kbvf, kbsf, kbvl, kbsl, vkbv *edwards.PrivateKey | ||
| pkbsf, pkbs *edwards.PublicKey | ||
| kaf, kal *secp256k1.PrivateKey | ||
| pkal, pkaf, pkasl, pkbsl *secp256k1.PublicKey | ||
| kbsfDleag, kbslDleag [libsecp256k1.ProofLen]byte |
There was a problem hiding this comment.
It's really hard to follow the code with these variable names. Something like ourSpendKey, counterPartySpendKey, etc. would make it way more understandable.
There was a problem hiding this comment.
Better clean these up on top of #2936? No reason to create conflicts there imo.
JoeGruffins
force-pushed
the
xmrscripts
branch
2 times, most recently
from
fc1f63d
to
d6b0917
Compare
JoeGruffins
force-pushed
the
xmrscripts
branch
from
d6b0917
to
0fce615
Compare
JoeGruffins
force-pushed
the
xmrscripts
branch
2 times, most recently
from
418bfcf
to
0101a5b
Compare
JoeGruffins
force-pushed
the
xmrscripts
branch
from
0101a5b
to
ac416c1
Compare
| "github.com/haven-protocol-org/monero-go-utils/base58" | ||
| ) | ||
|
|
||
| // TODO: Verification at all stages has not been implemented yet. |
There was a problem hiding this comment.
This TODO still valid?
There was a problem hiding this comment.
Yes, we are not inspecting the on-chain txn at all yet. In the end we will get a lot of the info from transactions, not straight from the other party.
Add a c library that has some primitive cryptographic functions needed for working with adaptor signatures.
get transaction development details from monerod including tx lock time; which is different from 'locked'/'unlocked' which refer to when a tx has 10 confirmations. Tx locktime can be any number of blocks in the future.
- Rename monero_functions.inc -> monero_functions - Tidy extra whitespace at eol for harness.sh & monero_functions.
New monero-wallet-rpc server with no attached wallet. This is for programmatically creating/generating and using a new wallet. The wallet will be generated in "own" dir but can be named what- ever you need: "alice", "Bob", etc.
JoeGruffins
force-pushed
the
xmrscripts
branch
from
ac416c1
to
8c5276c
Compare
closes #2754