-
Notifications
You must be signed in to change notification settings - Fork 123
docs: wiki restructuring #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: wiki restructuring #3026
Conversation
0bc9ec3
to
0309e10
Compare
0309e10
to
7f43d9c
Compare
2b1ea69
to
4145780
Compare
4145780
to
7a2f541
Compare
7a2f541
to
1f9fdaa
Compare
Looks great! .. really clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review
It is recommended to export your DCRDEX account information whenever they are created since your bonds | ||
are not automatically restored from just the application seed, refer to the | ||
[Export DCRDEX Account](Managing-your-DCRDEX-Accounts#export-dcrdex-account) section of this wiki for | ||
more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some bonds are restored automatically now #2613 but maybe no need to say that...
The seed actually has all the private data needed to restore accounts and bonds, the problem is that we don't know where to look currently. A version 2 bond could fix this.
Adding support for an asset is accomplished by writing a | ||
[Go](https://golang.org/) package with types that implement a particular set of | ||
interfaces, defined [here](https://github.com/decred/dcrdex/blob/master/server/asset/common.go) | ||
and [here](https://github.com/decred/dcrdex/blob/master/server/asset/driver.go). | ||
There are then two ways to import the asset backend into the server software. | ||
|
||
1. The package is compiled with -``buildmode=plugin`` and imported at runtime by specifying | ||
the plugin in the server configuration. | ||
2. The backend is added to the dcrdex repository, and imported directly at compile time. | ||
|
||
With the exception of a small handful of assets which will be implemented during | ||
initial phases of DEX development, it is expected that development communities | ||
will release their own appropriately vetted plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how accurate this is. I have never tried buildmode=plugin
This also doesn't say anything about client. And the development communities haven't shown their faces yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unchanged from the previous version, could leave as is or remove - whatever makes more sense really
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks for this!
While Bison Wallet's native wallets can be restored from the application's seed, | ||
the DCRDEX server accounts bonds need to be backed up separately. This is done by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we only return current and past bonds, so every time a new bond is created one would need to do this.. Maybe no need to say anything though. Any current bonds reported by the server are restored without this info and just seed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about expired bonds? e.g. if they've been posted, expired while the client was offline and now its restored on a new install? I guess it doesn't make a difference unless you're regularly exporting your accounts, which doesn't seem like something most users would do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if a bond expires and they restore from seed it is lost without having exported that bond info and importing after restoring currently. related #3141
0a60b62
to
97c2f75
Compare
addresses #2990
This PR covers the following sections: