libxc/binance: Fix polygon symbol conversion #3118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the conversion from MATIC -> POL, the symbol conversion for polygon and polygon tokens was not working properly. This is fixed.
martonp
force-pushed
the
fixPolygonSymbolConv
branch
from
6e30960 to
5c4ae6e
Compare
dev-warrior777
approved these changes
Dec 12, 2024
JoeGruffins
approved these changes
Jan 10, 2025
buck54321
reviewed
Jan 14, 2025
client/mm/libxc/binance.go
Outdated
| } | ||
|
|
||
| var binanceToDexSymbol = make(map[string]string) | ||
|
|
||
| func convertBnCoin(coin string) string { | ||
| // convertBnCoin converts a binance coin symbol to a dex symbol. | ||
| func convertBnCoin(coin string, weth bool) string { |
There was a problem hiding this comment.
I'm scratching my head a little at the meaning of the weth bool argument.
martonp
force-pushed
the
fixPolygonSymbolConv
branch
from
00361d5 to
efe1816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the conversion from MATIC -> POL (#2957), the symbol conversion for polygon and polygon tokens was not working properly. This is fixed.